Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Extensions + RPC Caching #35

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 15, 2024

PR-Codex overview

The focus of this PR is to add NFT-related functionalities such as NFTType, NFT, and NFTMetadata structs, along with ERC721 and ERC1155 extensions for total supply and token retrieval.

Detailed summary

  • Added NFTType, NFT, and NFTMetadata structs
  • Included ERC721 and ERC1155 extensions for total supply and token retrieval
  • Updated null checks and tests for ERC721 and ERC1155 extensions

The following files were skipped due to too many changes: Thirdweb.Tests/Thirdweb.NFTExtension.Tests.cs, Thirdweb/Thirdweb.NFT/ThirdwebNFTExtensions.cs, Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper changed the title NFT Extensions + Simplify NFT Extensions + RPC Caching Jun 17, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.01449% with 80 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (7b684e5) to head (de01e90).

Files Patch % Lines
Thirdweb/Thirdweb.NFT/ThirdwebNFTExtensions.cs 73.04% 34 Missing and 4 partials ⚠️
...b/Thirdweb.Contracts/ThirdwebContractExtensions.cs 25.00% 30 Missing and 3 partials ⚠️
Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs 91.93% 4 Missing and 1 partial ⚠️
Thirdweb/Thirdweb.Contracts/ThirdwebContract.cs 82.35% 1 Missing and 2 partials ⚠️
Thirdweb/Thirdweb.NFT/NFTTypes.cs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   93.25%   90.64%   -2.61%     
==========================================
  Files          24       26       +2     
  Lines        2015     2256     +241     
  Branches      228      255      +27     
==========================================
+ Hits         1879     2045     +166     
- Misses         97      163      +66     
- Partials       39       48       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 1767f75 into main Jun 17, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/nft-extensions branch June 17, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants